Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3355

Make force kill delay for workers follow the supervisor's SUPERVISOR_WORKER_SHUTDOWN_SLEEP_SECS

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • None

    Description

      We currently have the supervisor.worker.shutdown.sleep.secs parameter allowing users to specify how long the supervisor should wait between starting the initial graceful shutdown of a worker, and sending the followup force kill.

      When workers are asked to shut down gracefully, they run a shutdown hook that allows 1 second of cleanup, before force halting the JVM. I think it would be good to make the delay between starting the shutdown hook and halting the JVM follow the same config as in the supervisor.

      I don't see why it is useful to specify the force kill delay in the supervisor, if the worker just suicides after one second anyway. Letting the user configure how long shutdown is allowed to take lets them make use of the bolt's cleanup method for cleaning up resources in non-crash scenarios.

      Use case here https://stackoverflow.com/questions/55024919/resource-clean-up-after-killing-storm-topology

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            srdo Stig Rohde Døssing
            srdo Stig Rohde Døssing
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                Slack

                  Issue deployment